Tag unknown third party requests (so you can keep track of them) (#2405)

sitespeedio · Apr 1, 2019 · 4aa8217 · 4aa8217
1 parent de86528
commit 4aa8217
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/plugins/html/templates/url/thirdparty/index.pug b/lib/plugins/html/templates/url/thirdparty/index.pug
@@ -21,9 +21,10 @@ if thirdparty.category && Object.keys(thirdparty.category).length > 0
             table(data-sortable, id='thirdPartyTools')
                 +rowHeading(['Category', 'Number of tools'])
                 each metric, category in thirdparty.category
-                    tr 
-                        td(data-title='Category') #{category} 
-                        +numberCell('Tools', metric.tools ? metric.tools.median : Object.keys(thirdparty.toolsByCategory[category]).length)
+                    if (category !== 'unknown')
+                        tr 
+                            td(data-title='Category') #{category}     
+                            +numberCell('Tools', metric.tools ? metric.tools.median :Object.keys(thirdparty.toolsByCategory[category]).length)
 
 if thirdparty.assets && Object.keys(thirdparty.assets).length > 0
     h3 Third party requests and tools

diff --git a/lib/plugins/thirdparty/index.js b/lib/plugins/thirdparty/index.js
@@ -38,7 +38,7 @@ module.exports = {
           }
         }
       }
-      const byCategory = {};
+      const byCategory = { unknown: 0 };
       this.groups[message.url] = message.group;
       for (let asset of message.data.assets) {
         const entity = getEntity(asset.url);
@@ -73,6 +73,11 @@ module.exports = {
             }
             toolsByCategory[category][entity.name] = 1;
           }
+        } else {
+          // We don't have a match for this request, check agains the regex
+          if (!asset.url.match(firstPartyRegEx)) {
+            byCategory['unknown'] = byCategory['unknown'] + 1;
+          }
         }
       }
       aggregator.addToAggregate(message.url, byCategory, toolsByCategory);