verify that we have a url before third party web tries to get the domain

sitespeedio · Jun 20, 2019 · c6670af · c6670af
1 parent e641b3c
commit c6670af
Showing 1 changed file with 17 additions and 14 deletions.
diff --git a/lib/plugins/thirdparty/index.js b/lib/plugins/thirdparty/index.js
@@ -102,20 +102,23 @@ module.exports = {
       const cpuPerTool = {};
       if (message.data.cpu && message.data.cpu.urls) {
         for (let ent of message.data.cpu.urls) {
-          let entity = getEntity(ent.url);
-          // fallback to domain
-          if (!entity) {
-            const hostname = ent.url.startsWith('http')
-              ? urlParser.parse(ent.url).hostname
-              : ent.url;
-            entity = {
-              name: hostname
-            };
-          }
-          if (cpuPerTool[entity.name]) {
-            cpuPerTool[entity.name] += ent.value;
-          } else {
-            cpuPerTool[entity.name] = ent.value;
+          // Seen errors like  "Unable to find domain in "about:blank"
+          if (ent.url && ent.url.startsWith('http')) {
+            let entity = getEntity(ent.url);
+            // fallback to domain
+            if (!entity) {
+              const hostname = ent.url.startsWith('http')
+                ? urlParser.parse(ent.url).hostname
+                : ent.url;
+              entity = {
+                name: hostname
+              };
+            }
+            if (cpuPerTool[entity.name]) {
+              cpuPerTool[entity.name] += ent.value;
+            } else {
+              cpuPerTool[entity.name] = ent.value;
+            }
           }
         }
       }