Add visual metrics data to each run before we generate filmstrip data (…

…#2700)
sitespeedio · Oct 13, 2019 · f774ba3 · f774ba3
1 parent af430a8
commit f774ba3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/lib/plugins/browsertime/filmstrip.js b/lib/plugins/browsertime/filmstrip.js
@@ -43,7 +43,7 @@ function getMetricsFromBrowsertime(data) {
       metrics.push({
         metric: 'longTask',
         name: 'CPU Long Task duration',
-        value: longTask.startTime,
+        value: longTask.startTime.toFixed(0),
         duration: longTask.duration.toFixed(0)
       });
     }

diff --git a/lib/plugins/browsertime/index.js b/lib/plugins/browsertime/index.js
@@ -171,6 +171,13 @@ module.exports = {
           }
           let runIndex = 0;
           for (let run of result[resultIndex].browserScripts) {
+            // Kind of ugly way to add visualMetrics to a run
+            // it's outside of browserScripts today
+            // we could instead pass browsertime.visualMetrics maybe
+            if (result[resultIndex].visualMetrics) {
+              run.visualMetrics = result[resultIndex].visualMetrics[runIndex];
+            }
+
             let harIndex = runIndex * result.length;
             harIndex += resultIndex;
             if (result.har) {
@@ -238,14 +245,6 @@ module.exports = {
                 );
               }
             }
-
-            // Kind of ugly way to add visualMetrics to a run
-            // it's outside of browserScripts today
-            // we could instead pass browsertime.visualMetrics maybe
-            if (result[resultIndex].visualMetrics) {
-              run.visualMetrics = result[resultIndex].visualMetrics[runIndex];
-            }
-
             if (result[resultIndex].cpu) {
               run.cpu = result[resultIndex].cpu[runIndex];
             }