Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox HAR always says Chrome as browser #704

Closed
soulgalore opened this issue Jul 18, 2015 · 2 comments
Closed

Firefox HAR always says Chrome as browser #704

soulgalore opened this issue Jul 18, 2015 · 2 comments
Labels
bug

Comments

@soulgalore
Copy link
Member

Ok, the problem is that we adds a default User Agent (chrome) and that one is used by BrowserMobProxy. To get the right browser and version in the HAR, we need to either stop setting user agent if we run as default (but what do we then use for the crawler?) or hack Firefox/IE HAR files. ping @tobli lets discuss this.
@soulgalore soulgalore added the bug label Jul 18, 2015
@soulgalore soulgalore changed the title Testing with multiple browsers generates wrong HAR files (we get the first one two times) Firefox HAR always says Chrome as browser Jul 18, 2015
soulgalore added a commit that referenced this issue Jul 18, 2015
@soulgalore
Adds sitespeed and browser version(s) #703 but is depending on #704
75607c7
@soulgalore
Copy link
Member Author

fixed in sitespeedio/browsertime#90 so we just need to release and upgrade.

@soulgalore
Copy link
Member Author

fixed in latest BT and integrated.

@soulgalore soulgalore mentioned this issue Jul 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soulgalore