Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating budget file friendlyname.js to support all contentTypes #2374

Merged
merged 3 commits into from
Mar 19, 2019

Conversation

PedroMSantosD
Copy link
Contributor

Your checklist for a pull request to sitespeed.io

Please review the guidelines for contributing to this repository.

  • I'm making a big change or adding functionality so I've already opened an issue proposing the change to other contributors, so I got feedback on the idea before took the time to write precious code
  • Check that your change/fix has corresponding unit tests (if applicable)
  • Squash commits so it looks sane
  • Update the documentation https://github.com/sitespeedio/sitespeed.io/tree/master/docs in another PR
  • Verify that the test works by running npm test and test linting by npm run lint

Description

Please describe your pull request and tell us the fix #

Thank you for making sitespeed.io even better!

@soulgalore
Copy link
Member

Thanks @PedroMSantosD I'll merge this early next week when we can do a new minor release (hopefully with more functionality). I'll be totally off from internet later this week so I'll only release patches until then.

If you can run npm run lint:fix then the Travis tests will pass :)

Best
Peter

@soulgalore soulgalore merged commit 1cf3913 into sitespeedio:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants