Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use of browsertime.connectivity.alias option #2397

Merged
merged 1 commit into from Mar 29, 2019

Conversation

fholzer
Copy link
Contributor

@fholzer fholzer commented Mar 28, 2019

Description

Browsertime supports connectivity.alias option to give connectivity profiles a custom name, though this is not documented in the Sitespeed cli help, and not consistently used in Sitespeed. (only used for writing to DB, but not in reports)

This PR

  • adds option to sitespeed cli
  • uses the alias in html reports
  • adds documentation

Cheers,
Ferdinand

@soulgalore
Copy link
Member

Ah great, thanks @fholzer ! Can you just remove the change in config.md, that file is auto-generated on a release, so when we release your change, the documentation will automatically be updated.

Best
Peter

@fholzer
Copy link
Contributor Author

fholzer commented Mar 28, 2019

oh, didn't know. Done
Cheers/f

@soulgalore soulgalore merged commit aa9b167 into sitespeedio:master Mar 29, 2019
@soulgalore
Copy link
Member

Perfect thanks @fholzer !

@fholzer fholzer deleted the connectivity-alias branch March 29, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants