Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat -verify http status in budget (and log errors) #2691

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

thapasya-m
Copy link
Contributor

on budget verify, check for responseCode from
pagexray message body and log any status code > 399

Your checklist for a pull request to sitespeed.io

Please review the guidelines for contributing to this repository.

  • I'm making a big change or adding functionality so I've already opened an issue proposing the change to other contributors, so I got feedback on the idea before took the time to write precious code
  • Check that your change/fix has corresponding unit tests (if applicable)
  • Squash commits so it looks sane
  • Update the documentation https://github.com/sitespeedio/sitespeed.io/tree/master/docs in another PR
  • Verify that the test works by running npm test and test linting by npm run lint

Description

Please describe your pull request and tell us the fix #
2318
Thank you for making sitespeed.io even better!

@thapasya-m thapasya-m force-pushed the feat-budget-err-handling branch 3 times, most recently from a43c65c to 1b45533 Compare October 10, 2019 14:20
on budget verify, check for responseCode from
pagesummary and log any status code > 399
configure budget httpErrors = 0
@soulgalore soulgalore changed the title feat - log http error(s) for user given url feat -verify http status in budget (and log errors) Oct 10, 2019
@soulgalore soulgalore merged commit 0889548 into sitespeedio:master Oct 10, 2019
@soulgalore
Copy link
Member

Thank you @thapasya-m looked great! Can you do a small follow up PR where you just updates the docs so that the new value is there: https://www.sitespeed.io/documentation/sitespeed.io/performance-budget/#full-example

I'll merge that when I do the next release (probably on Saturday.

@thapasya-m
Copy link
Contributor Author

Thank you @thapasya-m looked great! Can you do a small follow up PR where you just updates the docs so that the new value is there: https://www.sitespeed.io/documentation/sitespeed.io/performance-budget/#full-example

I'll merge that when I do the next release (probably on Saturday.
Thanks, @soulgalore. I will make a follow-up documentation PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants