Add RowMap to go along with ColumnMap #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for i, key := range header { | ||
| result[key] = row[i] | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this going to work for when you have more than one row in the table? it seems like result[key] is going to keep getting overwritten until the last row?
There was a problem hiding this comment.
Yeah. RowMap should return a []map[string]string instead.
There was a problem hiding this comment.
I would something named Map to return a single map.
There was a problem hiding this comment.
Open to suggestions on a new name.
| @@ -38,6 +38,23 @@ func ColumnMap(table Table) map[string]string { | |||
| return result | |||
| } | |||
|
|
|||
| func RowMap(table Table) []map[string]string { | |||
There was a problem hiding this comment.
I think this be plural; RowMaps or maybe MapRows...
|
🚵 |
zombor
added a commit
that referenced
this pull request
Apr 21, 2015
Add RowMap to go along with ColumnMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.