Check for invalid page size

siuying · Jun 19, 2011 · 5904879 · 5904879
1 parent d1af2df
commit 5904879
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/CHANGELOG.markdown b/CHANGELOG.markdown
@@ -1,6 +1,7 @@
 # leaderboard 1.0.6 (in progress)
 
  * Added `disconnect` method
+ * Check for invalid page size when changing
 
 # leaderboard 1.0.5 (2011-05-04)
 

diff --git a/lib/leaderboard.rb b/lib/leaderboard.rb
@@ -32,6 +32,12 @@ def initialize(leaderboard_name, host = DEFAULT_REDIS_HOST, port = DEFAULT_REDIS
     @redis_connection = Redis.new(@redis_options)
   end
 
+  def page_size=(page_size)
+    page_size = DEFAULT_PAGE_SIZE if page_size < 1
+
+    @page_size = page_size
+  end
+
   def disconnect
     @redis_connection.client.disconnect
   end

diff --git a/test/test_leaderboard.rb b/test/test_leaderboard.rb
@@ -189,6 +189,14 @@ def test_can_change_page_size_and_have_it_reflected_in_size_of_result_set
     assert_equal 5, @leaderboard.leaders(1).size
   end
 
+  def test_cannot_set_page_size_to_invalid_page_size
+    add_members_to_leaderboard(Leaderboard::DEFAULT_PAGE_SIZE)
+
+    @leaderboard.page_size = 0
+    assert_equal 1, @leaderboard.total_pages
+    assert_equal Leaderboard::DEFAULT_PAGE_SIZE, @leaderboard.leaders(1).size
+  end
+
   def test_score_and_rank_for
     add_members_to_leaderboard