Upgrade to springboot 3 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,12 +74,12 @@ module.exports = class extends Generator { | |||
| } | |||
|
|
|||
| _formatCodeMaven() { | |||
| const command = this._isWin() ? 'mvnw.bat' : './mvnw'; | |||
| const command = this._isWin() ? 'mvnw' : './mvnw'; | |||
There was a problem hiding this comment.
On Windows OS shouldn't we use mvnw.bat? Or, you considered WSL?
There was a problem hiding this comment.
I'm using windows Os and only normal command is working , i.e with out bat.
Ideally with bat also should work but couldn't figure it out the reason
sivaprasadreddy
approved these changes
Nov 28, 2022
Thank you, I have fixed merge conflicts. Can you check and merge the PR |
rajadilipkolli
added a commit
that referenced
this pull request
Dec 3, 2022
* Adds Renovate * 0.1.1 (#1) * Creating v0.1.1 * Upgrading libraries * letting database insert values to id column (#42) letting database insert values to id column instead of hardcoding values this makes more sense as we are connecting to original database * adds servers Item for running remotely (#44) * adds servers Item for running remotely Adding servers information allows user to run with both http and https scheme especially when working in remote development like gitpod * Using annotations to set serverURL * Removes Hardcoded application Name * Implements pagination for fetching all entities (#46) * Implements pagination for fetching all entities * adds more assertions * fixes issue with aws version * fixes issue with dependency management plugin * Changed to generic pageResult response * Removes leftover code to fix issue * adds missing plural name * adds logstash logback encoder when elk is selected (#45) * adds logstash logback encoder when elk is selected * adds logstash configuration * upgradle maven and gradle wrappers (#48) * fixes issue with tableName when entityName has camelCase (#51) * fixes #47 * fixes issue with migration scripts * fixes issue with sequnce name in entity * using OOTB location of liquibase (#50) * using OOTB location of liquibase * revert loc in sync with saperation of concerns * fixes issue with npm tests * Upgrade to springboot 3 (#49) * Upgrade to springboot 3 * migrate to new way of configuration * fixes issues with generation aws sample * fixes issue generating & starting gradle project * removes zalando starter * typo fix * changing type of test to integrationTest * add Service Junit Test * Polish implementation and gitpod config * fixes issue with hardcoded assertion * Using JPA New mappings Co-authored-by: K Siva Prasad Reddy <sivaprasadreddy.k@gmail.com> * removes package rules * Update dependency chai to v4.3.7 (#3) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency sinon to v14.0.2 (#4) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update docker.elastic.co/elasticsearch/elasticsearch Docker tag to v7.17.7 (#6) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update docker.elastic.co/kibana/kibana Docker tag to v7.17.7 (#7) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update docker.elastic.co/logstash/logstash Docker tag to v7.17.7 (#8) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update eclipse-temurin Docker tag to v17.0.5_8-jre-focal (#9) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency mocha to v10.1.0 (#10) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update prom/prometheus Docker tag to v2.40.3 (#13) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update grafana/grafana Docker tag to v9.2.6 (#12) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency yeoman-environment to v3.12.1 (#11) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency chalk to v5 (#14) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Reverts changes to yo module Co-authored-by: K Siva Prasad Reddy <sivaprasadreddy.k@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ControllerAdvice