moves localstack to testcontainers dev mode #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rajadilipkolli
commented
Jun 11, 2023
•
rajadilipkolli
commented
- Moves LocalstackContainers configuration to dev mode
| import org.springframework.test.context.DynamicPropertyRegistry; | ||
| import org.testcontainers.containers.localstack.LocalStackContainer; | ||
| <%_ } _%> | ||
| import org.testcontainers.utility.DockerImageName; | ||
|
|
||
| @TestConfiguration(proxyBeanMethods = false) | ||
| public class TestApplication { |
There was a problem hiding this comment.
Usually a common approach is having a separate ContainersConfig.java and TestApplication.java
There was a problem hiding this comment.
I got inspire from start.spring.io generated code where both are present in same class. earlier, I used to manage two classes as you have suggested. As I don't see any significant gain creating two classes, can we continue in a single class?
There was a problem hiding this comment.
I still see start.spring.io generating 2 different files: https://start.spring.io/#!type=maven-project&language=java&packaging=jar&jvmVersion=17&groupId=com.sivalabs&artifactId=myapp&name=myapp&packageName=com.sivalabs.myapp&dependencies=lombok,web,data-jpa,flyway,h2,postgresql,validation,actuator,devtools,configuration-processor,testcontainers
There was a problem hiding this comment.
Aah, my bad. Yes it's generating a single file.
sivaprasadreddy
approved these changes
Jun 13, 2023
sivaprasadreddy
pushed a commit
that referenced
this pull request
Jun 16, 2023
rajadilipkolli
added a commit
that referenced
this pull request
Jun 23, 2023
* Update version in preparation of next release * Upgrade version * 0.1.3 (#74) * Create renovate.json * Update dependency chai to v4.3.7 * Update dependency gradle to v7.6.1 * Update docker.elastic.co/elasticsearch/elasticsearch Docker tag to v7.17.9 (#4) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency sinon to v14.0.2 (#3) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update docker.elastic.co/kibana/kibana Docker tag to v7.17.9 (#6) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update docker.elastic.co/logstash/logstash Docker tag to v7.17.9 (#7) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update eclipse-temurin Docker tag to v17.0.6_10-jre-focal (#8) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency googleJavaFormat to v1.16.0 (#9) * Update dependency googleJavaFormat to v1.16.0 * upgrade to latest version for maven build --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Raja Kolli <rajadilipkolli@gmail.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Updating dependencies * Fix code formatting task both outside module and with in model path * introducing testcontainers in dev mode and increment (#76) * introducing testcontainers in dev mode and increment * fixes issue with localstack * moves localstack to testcontainers dev mode (#77) * moving localstack to testcontainers dev mode * adds missing bracket * fixes issue with localstack in gradle project * adds schema validation Test (#78) * adds schema validation Test https://vladmihalcea.com/validate-ddl-schema-spring-hibernate/ changes as per this * renames testname * removing properties which are default in Hibernate 6+ (#79) * removing properties which is default in Hibernate 6+ * revert back to default * fixes issue with running initial script in localstack (#81) * fixes issue with running initial script in localstack and removes unused code * adds instructions to use TestContainers * fixes script * removes snapshot and milestone repository * fixes issue with generating code and refactor (#82) * fixes issue with generating project and refactor * removes unused files * Revert "moves localstack to testcontainers dev mode (#77)" This reverts commit c76aa2e. * Upgrading Gradle Wrapper * Fix gradle jacoco config issues * Upgrade to latest versions * Update dependency maven to v3.9.2 * fixes backward compatability and id collision issue (#83) * fixes broken grafana dashboards (#84) * Increase test timeout value * Upgrade Spring Boot version to 3.1.1 * Code clean up --------- Co-authored-by: Raja Kolli <rajadilipkolli@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.