Implements form field copy button #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <div> | |||
| <div class="flex content-center"> | |||
| <div v-show="isNotDirty"> | |||
There was a problem hiding this comment.
This is great feature! Tested locally and it works great. Thank you.
For some reason on my screen clipboard is all the way at the top of the line.
Adding class="pt-2" to <div v-show="isNotDirty"> fixes that
There was a problem hiding this comment.
What browser are you using?
There was a problem hiding this comment.
Chrome Version 72.0.3626.119 (Official Build) (64-bit)
Also tested on Safari Version 12.0.3 (14606.4.5)
There was a problem hiding this comment.
I just pushed a fix to this branch, can you let me know if it fixed it for you? I'll merge after that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the copy button to the form view.
Tasks
Related Issues/PRs
Steps to Verify Functionality
n/a