Added more algorithms support and public key file handling #14
Conversation
|
@sizeg is this package still maintained? |
|
Since there is no answer I've decided to make a fork and maintain this package on my own. If anyone is interested it's here: https://github.com/bizley/yii2-jwt |
|
@bizley this package maintained, but I can't get your PR. Most likely the next major update will be when version 4 of the package is released. |
|
Oh, I'm glad you are still on this, to be honest I've lost my hope after so many days. I don't see the point of keeping my fork if you are maintaining this package. Would you like me to prepare PR with all the things I've updated in your repo? We could merge to keep one package. |
|
@bizley i've added few changes from ur PR. Except prepareKey method. |
| } | ||
|
|
||
| if ($keyPath !== null) { | ||
| if (!file_exists($keyPath) || !is_readable($keyPath)) { |
There was a problem hiding this comment.
This check is already present here https://github.com/lcobucci/jwt/blob/3.2/src/Signer/Key.php#L61
|
Sure thing. |
No description provided.