Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version argument for functions that choose defaults #186

Closed
gustavdelius opened this issue Mar 23, 2021 · 2 comments
Closed

version argument for functions that choose defaults #186

gustavdelius opened this issue Mar 23, 2021 · 2 comments
Labels
discussion An idea that needs discussion before becoming a proposal enhancement New feature requests or suggestions for enhancement of existing features minor effort Resolving this issue will involve a minor effort setting parameters Issue relates to the part of mizer used for setting up MizerParams objects.
Milestone
Version 3.0

Comments

@gustavdelius
Copy link
Member

The functions newMultispeciesParams(), newTraitParams() and newCommunityParams() make a lot of choices for default values for parameters that are not provided by the user. Sometimes we find better ways to choose the defaults. The last time we changed defaults we introduced the above new names for the functions and kept the old functions around for backwards compatibility. We don't want to introduce new names for the functions each time we learn of a better way to choose defaults. So I propose a version argument that, if supplied, will make these functions use the defaults as they were in the corresponding version of mizer rather than the newest defaults.
@gustavdelius gustavdelius added enhancement New feature requests or suggestions for enhancement of existing features discussion An idea that needs discussion before becoming a proposal minor effort Resolving this issue will involve a minor effort labels Mar 23, 2021
@gustavdelius gustavdelius changed the title version argument for functions that create new models version argument for functions that choose defaults Mar 23, 2021
@gustavdelius gustavdelius added the setting parameters Issue relates to the part of mizer used for setting up MizerParams objects. label Jul 5, 2021
@gustavdelius
Copy link
Member Author

I think that rather than adding a version argument to every single function that sets defaults, we should have a global option, perhaps implemented via functions version() and version()<-.

gustavdelius added a commit that referenced this issue Aug 1, 2021
@gustavdelius
Remove the version argument, at least until we have made a decision…
9a6a797 
… for the best mechanism, see #186.
@gustavdelius gustavdelius added this to the Version 2.3 milestone Aug 12, 2021
@gustavdelius gustavdelius mentioned this issue Aug 27, 2021
Closed
gustavdelius added a commit that referenced this issue Aug 31, 2021
@gustavdelius
Branch for working on #45, #171, #186. Adding new slots to MizerParam…
ad3f99b 
…s class and setting them to defaults in `emptyParams()`.
@gustavdelius
Copy link
Member Author

This is now implemented via defaults_edition().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion An idea that needs discussion before becoming a proposal enhancement New feature requests or suggestions for enhancement of existing features minor effort Resolving this issue will involve a minor effort setting parameters Issue relates to the part of mizer used for setting up MizerParams objects.
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
1 participant
@gustavdelius