fixes #85 #95
Closed
fixes #85 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the docstring of any function or method doesn't have the function signature, these changes could potentially create a problem. But since pybind11 docstrings already have the function signatures, we should be good to go. |
|
Thanks for the contribution. Superceeded by #112 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to split docs for overloaded functions separately. Added tests for the same.
The idea is to parse the docstrings (which are below the signature) while parsing the
function_signatures_from_docstringand set it in theFunctionSignature. Then, while generating the stubs, we can use the docstring from theFunctionSignatureinstead of the whole docstring.