Pylint fixes for #97

siznax · Dec 23, 2017 · 82d68ae · 82d68ae
1 parent e286669
commit 82d68ae
Showing 1 changed file with 19 additions and 10 deletions.
diff --git a/wptools/core.py b/wptools/core.py
@@ -138,16 +138,8 @@ def _load_response(self, action):
             raise LookupError(_query)
 
         if action == 'wikidata':
-            entities = data.get('entities')
-            if not entities:
-                raise LookupError(_query)
-            elif '-1' in entities:
-                raise LookupError(_query)
-            else:
-                item = list(entities.values())[0]
-                if 'missing' in item:
-                    errmsg = "wikidata item %s has been deleted" % item['id']
-                    raise LookupError(errmsg)
+            handle_wikidata_errors(data, _query)
+
         return data
 
     def _query(self, action, qobj):
@@ -253,6 +245,23 @@ def show(self):
         prettyprint(output)
 
 
+def handle_wikidata_errors(data, query):
+    """
+    Raises LookupError if wikidata error found
+    """
+    entities = data.get('entities')
+
+    if not entities:
+        raise LookupError(query)
+    elif '-1' in entities:
+        raise LookupError(query)
+    else:
+        item = list(entities.values())[0]
+        if 'missing' in item:
+            errmsg = "wikidata item %s has been deleted" % item['id']
+            raise LookupError(errmsg)
+
+
 def prettyprint(datastr):
     """
     Print page data strings to stderr