Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test enhancement #7

Merged
merged 1 commit into from
Aug 15, 2020
Merged

Test enhancement #7

merged 1 commit into from
Aug 15, 2020

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the * define all branch to run GitHub Action rather than running on master.
  • Add --do-not-cache-result option with ./vendor/bin/phpunit to avoid generating .phpunit.result.cache file.
  • Using the assertFalse to assert expected is false.
  • Using the assertNull to assert expected is null.

@sj-i sj-i merged commit 22ba479 into sj-i:master Aug 15, 2020
@sj-i
Copy link
Owner

sj-i commented Aug 15, 2020

Thanks!

@peter279k peter279k deleted the test_enhancement branch August 15, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peter279k @sj-i