Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Then should be allowed as function name #182

Closed
triwav opened this issue Feb 26, 2019 · 0 comments · Fixed by #186
Closed

Then should be allowed as function name #182

triwav opened this issue Feb 26, 2019 · 0 comments · Fixed by #186
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior parser Affects this project's token parser
Projects
Issue Triage

Comments

@triwav
Copy link

triwav commented Feb 26, 2019 •
edited
Loading

If you have something like the following:

sendAppConfigNetworkRequest().then(sub(node)
    ....
end sub)

You get the message Expected property name after '.' as it doesn't know that then is actually the name of the function.
@sjbarag sjbarag added this to Needs triage in Issue Triage via automation Feb 26, 2019
@sjbarag sjbarag moved this from Needs triage to High priority in Issue Triage Feb 27, 2019
@sjbarag sjbarag added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior parser Affects this project's token parser labels Feb 27, 2019
sjbarag added a commit that referenced this issue Mar 1, 2019
@sjbarag
fix(lex,parse,e2e): Allow 'then' as a property
11789b2 
The `then` keyword isn't _actually_ a keyword, in that it can be used as
a valid identifier.  But it's still reserved as far as I can tell?

fixes #182
sjbarag added a commit that referenced this issue Mar 1, 2019
@sjbarag
fix(lex,parse,e2e): Allow 'then' as a property
fdbbd61 
The `then` keyword isn't _actually_ a keyword, in that it can be used as
a valid identifier.  But it's still reserved as far as I can tell?

fixes #182
@sjbarag sjbarag mentioned this issue Mar 1, 2019
Merged
Issue Triage automation moved this from High priority to Closed Mar 1, 2019
sjbarag added a commit that referenced this issue Mar 1, 2019
@sjbarag
fix(lex,parse,e2e): Allow 'then' as a property (#186)
a5bed11 
The `then` keyword isn't _actually_ a keyword, in that it can be used as
a valid identifier.  But it's still reserved as far as I can tell?

fixes #182
@sjbarag sjbarag mentioned this issue Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior parser Affects this project's token parser
Projects
Issue Triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lex,parse,e2e): Allow 'then' as a property sjbarag/brs
2 participants
@sjbarag @triwav