Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lex,parse,e2e): Allow 'then' as a property #186

Merged
merged 1 commit into from
Mar 1, 2019
Merged

fix(lex,parse,e2e): Allow 'then' as a property #186

merged 1 commit into from
Mar 1, 2019

Conversation

sjbarag
Copy link
Owner

@sjbarag sjbarag commented Mar 1, 2019

The then keyword isn't actually a keyword, in that it can be used as a valid identifier. But it's still reserved as far as I can tell?

fixes #182

@sjbarag
fix(lex,parse,e2e): Allow 'then' as a property
fdbbd61 
The `then` keyword isn't _actually_ a keyword, in that it can be used as
a valid identifier.  But it's still reserved as far as I can tell?

fixes #182
@sjbarag sjbarag added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior e2e Affects this project's end-to-end test cases (the BrightScript sample files executed during testing) lexer Affects this project's lexer (aka scanner) parser Affects this project's token parser labels Mar 1, 2019
@sjbarag
Copy link
Owner Author

sjbarag commented Mar 1, 2019

(inb4 I find this PR again in 9 weeks and realize that I've done something wrong 🤷‍♂️)

@sjbarag sjbarag merged commit a5bed11 into master Mar 1, 2019
@sjbarag sjbarag deleted the allow-then-property branch March 1, 2019 17:22
sjbarag added a commit that referenced this pull request Mar 5, 2019
@sjbarag
fix(parse): Allow mixed-case then
662c977 
Commit a5bed11 (#186) caused a regression in the if-statement parsing
code in which mixed-case `then`s were no longer allowed.  This fixes
that!
@sjbarag sjbarag mentioned this pull request Mar 5, 2019
Merged
sjbarag added a commit that referenced this pull request Mar 5, 2019
@sjbarag
fix(parse): Allow mixed-case then
1671188 
Commit a5bed11 (#186) caused a regression in the if-statement parsing
code in which mixed-case `then`s were no longer allowed.  This fixes
that!

fixes #187
sjbarag added a commit that referenced this pull request Mar 5, 2019
@sjbarag
fix(parse): Allow mixed-case then (#188)
04e37b8 
Commit a5bed11 (#186) caused a regression in the if-statement parsing
code in which mixed-case `then`s were no longer allowed.  This fixes
that!

fixes #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior e2e Affects this project's end-to-end test cases (the BrightScript sample files executed during testing) lexer Affects this project's lexer (aka scanner) parser Affects this project's token parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Then should be allowed as function name
1 participant
@sjbarag