Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capital letters in then portion of conditional statement causes parse errors #187

Closed
TwitchBronBron opened this issue Mar 5, 2019 · 0 comments · Fixed by #188
Closed

Capital letters in then portion of conditional statement causes parse errors #187

TwitchBronBron opened this issue Mar 5, 2019 · 0 comments · Fixed by #188
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior parser Affects this project's token parser
Projects
Issue Triage

Comments

@TwitchBronBron
Copy link
Contributor

Using any capital letters in the then portion of an if statement causes a parse error.
image

sub Main()
    if true Then
        print "Hello world"
    end if
end sub
@TwitchBronBron TwitchBronBron mentioned this issue Mar 5, 2019
Closed
@sjbarag sjbarag added this to Needs triage in Issue Triage via automation Mar 5, 2019
@sjbarag sjbarag moved this from Needs triage to High priority in Issue Triage Mar 5, 2019
@sjbarag sjbarag added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior parser Affects this project's token parser labels Mar 5, 2019
@sjbarag sjbarag mentioned this issue Mar 5, 2019
Merged
sjbarag added a commit that referenced this issue Mar 5, 2019
@sjbarag
fix(parse): Allow mixed-case then
1671188 
Commit a5bed11 (#186) caused a regression in the if-statement parsing
code in which mixed-case `then`s were no longer allowed.  This fixes
that!

fixes #187
Issue Triage automation moved this from High priority to Closed Mar 5, 2019
sjbarag added a commit that referenced this issue Mar 5, 2019
@sjbarag
fix(parse): Allow mixed-case then (#188)
04e37b8 
Commit a5bed11 (#186) caused a regression in the if-statement parsing
code in which mixed-case `then`s were no longer allowed.  This fixes
that!

fixes #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior parser Affects this project's token parser
Projects
Issue Triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(parse): Allow mixed-case then sjbarag/brs
2 participants
@sjbarag @TwitchBronBron