fix(parser): Allow complex expressions on RHS of set statements #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser was a little bit too greedy when attempting to detect set statements, which I should have noticed with the weird workarounds in that function. Now that we're _not_ trying to read an entire expression as the left-hand side of a set statement (e.g. `foo + bar *= 3`), that complication can be removed. Arbitrarily complex expressions are now supported on the right-hand side of a set statement, e.g. `foo.bar = true and false or 3 > 4` fixes #156
sjbarag
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser was a little bit too greedy when attempting to detect set statements, which I should have noticed with the weird workarounds in that function. Now that we're not trying to read an entire expression as the left-hand side of a set statement (e.g.
foo + bar *= 3), that complication can be removed.Arbitrarily complex expressions are now supported on the right-hand side of a set statement, e.g.
foo.bar = true and false or 3 > 4fixes #156