Adding support for RoXMLElement

[Vasya-M]

supported interfaces:

parse
getName
getAttributes
getNamedElementsCi

see #282

[alimnios72]

This starts to look good, thanks for the great work here.
In addition to below comments I have a few more comments/questions

• Is the full ifXMLEelement interface going to be implemented here? or that's out of the scope of this PR?
• Can you please add some docs to the methods in theRoXMLElement class?
• Also please add e2e tests such as the following example: callFunc test
  callFunc script

[alimnios72]

there is a typo in the interface name ifXMLElement

[Vasya-M]

done

[alimnios72]

I think this could be private as it doesn't seem to be used outside this class

[sjbarag]

Once it's private, this function doesn't need to exist at all! A simple this.xmlNode = xmlElem would suffice, since we don't seem to be doing anything special here.

[Vasya-M]

ohh, forgot that RoXMLElement are friend (from C++, where other class/methods can access private members) for other RoXMLElement objects

[Vasya-M]

done

[alimnios72]

does XmlDocument return anything to indicate that the string was parsed correctly? something like a boolean value? or does it throws an exception in every case?

[vbuchii]

It throws an exception only if the XML can not be parsed at all, but it doesn't if it can parse at least part of XML and it returns true in that case. The similar behavior we have on Roku.

[sjbarag]

Hey @Vasya-M — thanks for the PR! This will be a very component to have implemented. You're off to a great start, but there's a good bit of cleanup to do before this lands. Most important is a set of end-to-end tests (brightscript files that we execute in jest test cases) that demonstrate that this works, as @alimnios72 called out. They don't need to be exhaustive tests — just calling each function once or twice to show off the use of roXMLElement.

I'm looking forward to getting this incorporated!

[sjbarag]

Once it's private, this function doesn't need to exist at all! A simple this.xmlNode = xmlElem would suffice, since we don't seem to be doing anything special here.

[Vasya-M]

doc for roXMLElement(ifXMLElement )

[sjbarag]

Looking much better! Let's just get some proper typing on RoXmlElement#xmlNode and this should be good to merge 😄

[sjbarag]

Thanks for the updates @Vasya-M — this seems safe to land assuming everything still works when I remove that test.only 😃