fix(nightly): fetch two commits to detect commits-since-last-build #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior for GitHub's `actions/checkout@v2` only fetches the latest commit [1], so our previous attempts to detect commits "since last night's nightly build" always failed. Fetch two commits to make it possible to detect commits in `main` within the past 25 hours. [1] https://github.com/actions/checkout/tree/25a956c84d5dd820d28caab9f86b8d183aeeff3d#checkout-v2
sjbarag
force-pushed
the
fetch-multiple-commits-for-nightly-builds
branch
from
593fef5
to
b623d8b
Compare
sjbarag
force-pushed
the
fetch-multiple-commits-for-nightly-builds
branch
from
c542a69
to
5b6b9c9
Compare
sjbarag
added
bug
|
Merged without review because this only impacts the nightly build (which currently succeeds but doesn't do anything), and I want to make sure things work when this runs at 10:05am PT 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior for GitHub's
actions/checkout@v2only fetches the latest commit [1], so our previous attempts to detect commits "since last night's nightly build" always failed. Fetch two commits to make it possible to detect commits inmainwithin the past 25 hours.[1] https://github.com/actions/checkout/tree/25a956c84d5dd820d28caab9f86b8d183aeeff3d#checkout-v2