-
Notifications
You must be signed in to change notification settings - Fork 231
How to get your pull request accepted
Simon Hughes edited this page Oct 12, 2022
·
9 revisions
Have a read of How to write the perfect pull request
My requirements are simple:
- Please edit the Generator project files! I have a build script which takes the Generator code and creates the
EF.Reverse.POCO.v3.ttinclude
file. So editing and debugging are all done within the C# Generator project. - Always keep the changes to a minimum, so I can see exactly what's changed in regard to the pull request. I.e. No whitespace tidy-up, etc.
- No tabs, only spaces (4).
- Only use C# 6 and below. Absolutely no C# 7 because VS 2015 cannot support the syntax.
- Don't move functions about, please leave them where they are.
- No new .ttinclude files. This will always get rejected.
- Don't be tempted to do a few different enhancements in one pull request. Have one pull request for one bug fix / enhancement.
- As a thank you, all merged (accepted) pull requests will receive a one-year commercial licence.
Many thanks for taking the time to read this, and for wanting to contribute.