This repository has been archived by the owner on Sep 11, 2019. It is now read-only.
Mutating operations incorrectly clear expiry #2
Comments
|
rename is affected (redis carries the expiry time with the rename), and setrange is also affected. getset is not affected: redis clears the expiry. |
bmerry
added a commit
that referenced
this issue
Nov 12, 2017
A new setx function is added to _StrKeyDict that updates the value but preserves the existing expiry time. This is used by mutating operations that replace the value rather than mutating it in-place (which is impossible for strings, and happens not to be done in some other cases). Fixes #2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A number of operations modify an existing value, then assign back to
self._db, which has the side-effect of clearing the expiry time. According to the redis documentation, only operations that completely replace a key (rather than modifying it) clear the expiry. I haven't written any tests yet, but looking at the code, it is probably at leastSome other operations where I'm not sure what redis will do
The text was updated successfully, but these errors were encountered: