This repository has been archived by the owner on Sep 11, 2019. It is now read-only.
Preserve expiry time when mutating keys #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new setx function is added to _StrKeyDict that updates the value but preserves the existing expiry time. This is used by mutating operations that replace the value rather than mutating it in-place (which is impossible for strings, and happens not to be done in some other cases). Fixes #2.
2 similar comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new setx function is added to _StrKeyDict that updates the value but
preserves the existing expiry time. This is used by mutating operations
that replace the value rather than mutating it in-place (which is
impossible for strings, and happens not to be done in some other
cases).
Fixes #2.