Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deploy test #1669

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Add deploy test #1669

merged 7 commits into from
Jan 30, 2024

Conversation

DimaStebaev
Copy link
Contributor

@DimaStebaev DimaStebaev commented Jan 15, 2024 •
edited
Loading

  • add deploy test
  • update ganache
  • remove drastically dirty estimateGas fix
  • improve pip and yarn caching

@DimaStebaev DimaStebaev linked an issue Jan 15, 2024 that may be closed by this pull request
Schain part of IMA contracts are failed to deploy #1668
Closed
@DimaStebaev DimaStebaev marked this pull request as draft January 15, 2024 19:23
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16ba275) 85.81% compared to head (b908915) 85.81%.

❗ Current head b908915 differs from pull request most recent head 99271d9. Consider uploading reports for the commit 99271d9 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1669   +/-   ##
========================================
  Coverage    85.81%   85.81%           
========================================
  Files           26       26           
  Lines         1466     1466           
  Branches       402      402           
========================================
  Hits          1258     1258           
  Misses          33       33           
  Partials       175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DimaStebaev DimaStebaev marked this pull request as ready for review January 16, 2024 14:49
yavrsky
yavrsky previously approved these changes Jan 16, 2024
View reviewed changes
@DimaStebaev DimaStebaev merged commit fae872b into develop Jan 30, 2024
7 checks passed
@DimaStebaev DimaStebaev deleted the deploy-fix branch January 30, 2024 11:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@yavrsky yavrsky yavrsky approved these changes

@sergiy-skalelabs sergiy-skalelabs sergiy-skalelabs left review comments

@payvint payvint Awaiting requested review from payvint payvint is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schain part of IMA contracts are failed to deploy
4 participants
@DimaStebaev @DmytroNazarenko @yavrsky @sergiy-skalelabs