Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticket-3 much better async calls #23

Merged
merged 15 commits into from
Nov 24, 2023
Merged

ticket-3 much better async calls #23

merged 15 commits into from
Nov 24, 2023

Conversation

sergiy-skalelabs
Copy link
Contributor

Refactored asynchronous calls like JSON RPC everywhere. Much less code indenting. Lot of big functions split into smaller ones.
No performance changes introduced.
No new tests needed.

@sergiy-skalelabs sergiy-skalelabs self-assigned this Nov 17, 2023
@sergiy-skalelabs sergiy-skalelabs linked an issue Nov 17, 2023 that may be closed by this pull request
Improve asynchronous call handlers #3
Closed
@sergiy-skalelabs sergiy-skalelabs marked this pull request as ready for review November 17, 2023 18:47
@sergiy-skalelabs sergiy-skalelabs changed the title ticket-3 much metter async calls ticket-3 much better async calls Nov 20, 2023
DmytroNazarenko
DmytroNazarenko reviewed Nov 20, 2023
View reviewed changes
src/bls.mjs Outdated Show resolved Hide resolved
src/imaCore.mjs Show resolved Hide resolved
DmytroNazarenko
DmytroNazarenko reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@DmytroNazarenko DmytroNazarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Move sleep function to separate file and import it where needed

src/discoveryTools.mjs Outdated Show resolved Hide resolved
src/oracle.mjs Outdated Show resolved Hide resolved
DmytroNazarenko
DmytroNazarenko requested changes Nov 24, 2023
View reviewed changes
src/clpTools.mjs Show resolved Hide resolved
src/main.mjs Outdated Show resolved Hide resolved
@sergiy-skalelabs sergiy-skalelabs merged commit e4c8af3 into develop Nov 24, 2023
15 checks passed
@sergiy-skalelabs sergiy-skalelabs deleted the ticket-3/much-better-asynchronous-calls branch November 24, 2023 20:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@badrogger badrogger badrogger approved these changes

@dmytrotkk dmytrotkk dmytrotkk approved these changes

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@kladkogex kladkogex Awaiting requested review from kladkogex

Assignees

@sergiy-skalelabs sergiy-skalelabs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve asynchronous call handlers
4 participants
@sergiy-skalelabs @badrogger @dmytrotkk @DmytroNazarenko