Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/add documentation #239

Merged
merged 17 commits into from
Jun 1, 2020
Merged

Conversation

cstrangedk
Copy link
Contributor

  • Added in-line documentation to delegation contracts
  • Added SPDX License ID

@cstrangedk cstrangedk marked this pull request as draft May 28, 2020 10:48
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #239 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #239   +/-   ##
========================================
  Coverage    94.80%   94.80%           
========================================
  Files           33       33           
  Lines         2463     2463           
  Branches       342      342           
========================================
  Hits          2335     2335           
  Misses         128      128           
Impacted Files Coverage Δ
contracts/ConstantsHolder.sol 87.09% <ø> (ø)
contracts/ContractManager.sol 100.00% <ø> (ø)
contracts/Decryption.sol 100.00% <ø> (ø)
contracts/ECDH.sol 96.29% <ø> (ø)
contracts/GroupsData.sol 91.66% <ø> (ø)
contracts/GroupsFunctionality.sol 75.60% <ø> (ø)
contracts/MonitorsData.sol 100.00% <ø> (ø)
contracts/MonitorsFunctionality.sol 99.29% <ø> (ø)
contracts/Nodes.sol 98.75% <ø> (ø)
contracts/Permissions.sol 78.57% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2abc09...7f5fb34. Read the comment docs.

kladkogex
kladkogex previously approved these changes May 28, 2020
@DimaStebaev DimaStebaev marked this pull request as ready for review June 1, 2020 07:55
DimaStebaev
DimaStebaev previously approved these changes Jun 1, 2020
@cstrangedk cstrangedk merged commit 0ddf6c1 into develop Jun 1, 2020
@cstrangedk cstrangedk deleted the enhancement/add-documentation branch June 1, 2020 13:58
Copy link
Contributor

@payvint payvint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants