Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle custom errors thrown by evm #1744

Open
Tracked by #1736
olehnikolaiev opened this issue Dec 6, 2023 · 3 comments · May be fixed by #1747
Open
Tracked by #1736

Handle custom errors thrown by evm #1744

olehnikolaiev opened this issue Dec 6, 2023 · 3 comments · May be fixed by #1747
Assignees
@olehnikolaiev
Labels
enhancement New feature or request
Milestone
SKALE 2.6

Comments

@olehnikolaiev
Copy link
Contributor

currently custom errors cannot be proccessed as revert reason, need to change it
@olehnikolaiev olehnikolaiev mentioned this issue Dec 6, 2023
Open
@DmytroNazarenko DmytroNazarenko added the enhancement New feature or request label Dec 6, 2023
@DmytroNazarenko DmytroNazarenko changed the title handle custom errors thrown by evm Handle custom errors thrown by evm Dec 6, 2023
@DmytroNazarenko DmytroNazarenko added this to the 2.3 milestone Dec 6, 2023
olehnikolaiev added a commit that referenced this issue Dec 8, 2023
@olehnikolaiev
#1744 handle custom errors in revert
c5ff090
olehnikolaiev added a commit that referenced this issue Dec 8, 2023
@olehnikolaiev
#1744 remove commented code
589dfb1
@olehnikolaiev olehnikolaiev linked a pull request Dec 8, 2023 that will close this issue
Open
olehnikolaiev added a commit that referenced this issue Dec 8, 2023
@olehnikolaiev
#1744 remove extra includes
747049f
@PolinaKiporenko PolinaKiporenko modified the milestones: 2.3, SKALE 2.3 Dec 8, 2023
@PolinaKiporenko PolinaKiporenko modified the milestones: SKALE 2.3, SKALE 2.4 Dec 18, 2023
@olehnikolaiev
Copy link
Contributor Author

blocked by tracing epic

@PolinaKiporenko
Copy link
Contributor

could be fixed by 2.3.1 release

@DmytroNazarenko
Copy link
Collaborator

Moved to 2.5 as non-critical

@DmytroNazarenko DmytroNazarenko modified the milestones: SKALE 2.4, SKALE 2.5 Mar 5, 2024
@DmytroNazarenko DmytroNazarenko modified the milestones: SKALE 2.5, SKALE 2.6 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olehnikolaiev olehnikolaiev

Labels
enhancement New feature or request
Projects
SKALE Engineering 🚀
Status: Ready For Pickup
Milestone
SKALE 2.6
Development

Successfully merging a pull request may close this issue.

Bug/1744 handle custom errors outside evm skalenetwork/skaled
3 participants
@DmytroNazarenko @olehnikolaiev @PolinaKiporenko