-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/1744 handle custom errors outside evm #1747
base: develop
Are you sure you want to change the base?
Conversation
SUGGESTIONS BEFORE MERGE:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3.18.0 #1747 +/- ##
===========================================
- Coverage 45.52% 36.46% -9.07%
===========================================
Files 356 356
Lines 51685 51767 +82
===========================================
- Hits 23532 18877 -4655
- Misses 28153 32890 +4737 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it compatible to the way it is done in geth.
In particular, for error message one simply needs to return a byte array as is.
There is no need for any processing.
Please look at geth code
fixes #1744
added unittests at
test/unittests/libweb3jsonrpc/jsonrpc.cpp: revertReason
to verify handling different revert messages and custom errors