Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1744 handle custom errors outside evm #1747

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Dec 8, 2023

fixes #1744

added unittests at test/unittests/libweb3jsonrpc/jsonrpc.cpp: revertReason to verify handling different revert messages and custom errors

@olehnikolaiev olehnikolaiev changed the base branch from develop to v3.18.0 December 8, 2023 16:18
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #1747 (3b6c5ab) into v3.18.0 (2fcb104) will decrease coverage by 9.07%.
The diff coverage is 4.76%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.18.0    #1747      +/-   ##
===========================================
- Coverage    45.52%   36.46%   -9.07%     
===========================================
  Files          356      356              
  Lines        51685    51767      +82     
===========================================
- Hits         23532    18877    -4655     
- Misses       28153    32890    +4737     

Copy link
Collaborator

@kladkogex kladkogex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it compatible to the way it is done in geth.

In particular, for error message one simply needs to return a byte array as is.

There is no need for any processing.

Please look at geth code

Base automatically changed from v3.18.0 to develop January 22, 2024 19:07
@DmytroNazarenko DmytroNazarenko marked this pull request as draft October 14, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle custom errors thrown by evm
2 participants