Allow usage in NodeJS with the embedded dagre module #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dagre module detects the module exports in the NodeJS environment and
does not declare the dagre object globally. The code in nomnoml.layouter.js
fails accessing the global dagre variable. Let's declate self = {} to make
dagre put its object to it, when running outside of the browser.
A better solution would be to require the dagre module like lodash and
limiting the supported versions to 0.4.x, which have the needed interface.
Perform the workaround to expose the dagre module result in the browser too. If RequireJS is used, dagre detects it and does not expose the dagre object globally in the window object. Another reason to integrate dagre as a module like lodash...
require('nomnoml').renderSvg(code);Now seems to work correctly, I believe this can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dagre module detects the module exports in the NodeJS environment and
does not declare the dagre object globally. The code in nomnoml.layouter.js
fails accessing the global dagre variable. Let's declare self = {} to make
dagre put its object to it, when running outside of the browser.
A better solution would be to require the dagre module like lodash and
limiting the supported versions to 0.4.x, which have the needed interface.
Let me know if you preferred that solution.
A part of the suggested fix for the issue #29.