Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of deprecated method calls #55

Closed
puzzlerbot opened this issue May 31, 2018 · 4 comments · Fixed by #88
Closed

Get rid of deprecated method calls #55

puzzlerbot opened this issue May 31, 2018 · 4 comments · Fixed by #88
Labels
hacktoberfest
Milestone
0.0.4

Comments

@puzzlerbot
Copy link

Check OpIgnoringUnprivildgedEventSenderTest and OpValidatingEventSignatureTest classes which use IOUtils.toString method, marked as deprecated.
@sebast26
Copy link
Contributor

sebast26 commented Oct 9, 2018

@puzzlerbot I can work on this issue.

@skapral
Copy link
Owner

skapral commented Oct 10, 2018 •
edited

@sebast26 thanks. You're welcome. Let me know if you have any questions.

sebast26 added a commit to sebast26/puzzlerbot that referenced this issue Oct 11, 2018
@sebast26
skapral#55: Uses IOUtils.toString method with explicit charset. Close…
9be3176 
…s stream with try-with-resource block.
@sebast26
Copy link
Contributor

@skapral Hi, I hope that you can find a time to look at #88

@sebast26 sebast26 mentioned this issue Oct 15, 2018
Merged
skapral pushed a commit that referenced this issue Oct 15, 2018
@sebast26 @skapral
#55: Uses IOUtils.toString method with explicit charset. Closes strea…
1e327c3 
…m with try-with-resource block.
@skapral
Copy link
Owner

skapral commented Oct 15, 2018

@sebast26 thanks

@skapral skapral added this to the 0.0.4 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
0.0.4
3 participants
@sebast26 @skapral @puzzlerbot