Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#55: Uses IOUtils.toString method with explicit charset. Closes stream with try-with-resource block. #88

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

sebast26
Copy link
Contributor

@sebast26 sebast26 commented Oct 11, 2018

Closes #55

Based on JavaDoc for IOUtils.toString (https://commons.apache.org/proper/commons-io/javadocs/api-2.6/org/apache/commons/io/IOUtils.html#toString-java.net.URL-)

Also I close streams because IOUtils by default do not close it (please follow class JavaDoc: "Wherever possible, the methods in this class do not flush or close the stream").

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #88   +/-   ##
=========================================
  Coverage     75.88%   75.88%           
  Complexity      107      107           
=========================================
  Files            56       56           
  Lines           506      506           
  Branches         18       18           
=========================================
  Hits            384      384           
  Misses          115      115           
  Partials          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe12c0...9be3176. Read the comment docs.

@skapral skapral merged commit 1e327c3 into skapral:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of deprecated method calls
2 participants