This repository has been archived by the owner on Jan 4, 2018. It is now read-only.
Polyfill slotting issue #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanging this test passes in Chrome Canary v54
part of this was to make the slot name change unregister / reregister. Another part was to make the slotNodeFromSlot function work under a closed shadow root, as assignedSlot would return null in this case. We still need to fix the function to work with setAttribute
…d nodes as children
| @@ -168,7 +168,7 @@ function slotNodeIntoSlot(slot, node, insertBefore) { | |||
| } | |||
|
|
|||
| function slotNodeFromSlot(node) { | |||
| const slot = node.assignedSlot; | |||
| const slot = nodeToSlotMap.get(node); | |||
There was a problem hiding this comment.
To make sure we can use get the slot when in closed mode
| const slotHasRoot = root; | ||
|
|
||
| if (slotHasRoot) { | ||
| removeSlotFromRoot(root, this); |
There was a problem hiding this comment.
Looks weird. Why are you doing this?
There was a problem hiding this comment.
I think it's because the previous DOM nodes must be unassigned. There might be a better way to do this, like unassignNodesFromSlot(). I'm thinking this might be able to be used elsewhere, too.
That said, I'd get this working and tests green before trying to refactor that now.
problem was that you can't put undefined into a weakmap
|
lGtm The capital G is for "GREAT". Also, to test the case sensitivity of gh |
|
lgtm |
1 similar comment
|
lgtm |
| @@ -54,7 +54,7 @@ describe('slot/distribution', () => { | |||
| expect(frag.childNodes.length).to.equal(0); | |||
| }); | |||
|
|
|||
| describe('changing slot name with three children', () => { | |||
| describe('changing slot name with more than two', () => { | |||
|
no lgtm from me until you fix airbnb linting ;p |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worked on this with @lukebatchelor