This repository has been archived by the owner on Jan 4, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Errors in FF and Safari using UglifyJS #21
Comments
It looks like this is related to #18 |
We are using the standard webpack uglifyJS plugin: plugins: [
new webpack.optimize.UglifyJsPlugin({
compress: {
warnings: false,
},
output: {
comments: true,
},
}),
] |
You can temporarily fix it by setting |
Spoke to @alexreardon IRL and they are using latest, but this is still an issue. |
The problem is in weakmap – it uses Function.prototype.name You can workaround it now by putting:
in your config, but we'll release a new version with a better weakmap dependency. |
jpnelson
added a commit
to skatejs/named-slots
that referenced
this issue
Oct 28, 2016
as descrived in skatejs/web-components#21 (comment) , use weak-map rather than weakmap fixes #133
jpnelson
added a commit
that referenced
this issue
Oct 28, 2016
Is this all good now josh? |
Yes, should be! If it's not let me know. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When running
skate-web-components
through UglifyJS I am getting a run time exception in firefox and safari.It seems like it is erroring out in the following dependency: https://github.com/Benvie/WeakMap
The text was updated successfully, but these errors were encountered: