Skip to content

Commit

Permalink
fix TestGrobufUsages
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewKostousov committed Jan 5, 2018
1 parent 76f2cf6 commit a5fc5d0
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions GrEmit.Tests/TestGrobufUsages.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ namespace GrEmit.Tests
public class TestGrobufUsages
{
[Test]
#if NETCOREAPP2_0
[Ignore("Test is failing on dotnetcore: dateTimeOffsetType.GetField(\"m_dateTime\", ...) == null")]
#endif
public void DateTimeOffsetPrivateFieldsAccess()
{
var method = BuildAccessorMethod();
Expand All @@ -27,10 +24,10 @@ private DynamicMethod BuildAccessorMethod()
using(var il = new GroboIL(method))
{
il.Ldarga(0); // stack: [obj]
il.Ldfld(dateTimeOffsetType.GetField("m_dateTime", BindingFlags.Instance | BindingFlags.NonPublic)); // stack: [obj.m_dateTime]
il.Ldfld(dateTimeOffsetType.GetField(SelectName("_dateTime", "m_dateTime"), BindingFlags.Instance | BindingFlags.NonPublic)); // stack: [obj.m_dateTime]

il.Ldarga(0); // stack: [obj]
il.Ldfld(dateTimeOffsetType.GetField("m_offsetMinutes", BindingFlags.Instance | BindingFlags.NonPublic)); // stack: [obj.m_offsetMinutes]
il.Ldfld(dateTimeOffsetType.GetField(SelectName("_offsetMinutes", "m_offsetMinutes"), BindingFlags.Instance | BindingFlags.NonPublic)); // stack: [obj.m_offsetMinutes]

il.Call(assertMethod); // stack: []

Expand All @@ -46,6 +43,15 @@ private static void AssertDateTimeOffsetFields(DateTime dateTime, short offsetMi
Assert.That(offsetMinutes, Is.EqualTo(15));
}

private static string SelectName(string netcoreName, string net45Name)
{
#if NETCOREAPP2_0
return netcoreName;
#else
return net45Name;
#endif
}

private readonly Type dateTimeOffsetType = typeof(DateTimeOffset);
private static readonly DateTimeOffset dateTimeOffset = new DateTimeOffset(new DateTime(2018, 01, 05, 21, 34, 56, DateTimeKind.Unspecified), TimeSpan.FromMinutes(15));
}
Expand Down

0 comments on commit a5fc5d0

Please sign in to comment.