Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new clicklabel class to qt makefile, remove old .png's #2

Merged
merged 1 commit into from
Dec 10, 2017

Conversation

TheCharlatan
Copy link

Adds the ClickLabel class to the qt makefile recipe, removed now unused
.png icon targets.

Adds the ClickLabel class to the qt makefile recipe, removed now unused
.png icon targets.
qt/res/icons/key.png \
qt/res/icons/lock_closed.png \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these still used?

qt/coincontroldialog.cpp: contextMenuItem->setIcon(COLUMN_CHECKBOX, QIcon(":/icons/lock_closed"));
qt/coincontroldialog.cpp: itemOutput->setIcon(COLUMN_CHECKBOX, QIcon(":/icons/lock_closed"));

Copy link
Author

@TheCharlatan TheCharlatan Dec 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That portion of code is commented out in coincontroldialog.cpp . Why is it commented out @skcin ?
Edit: In other files the lock_closed is changed correctly to .svg + whatever theme is used.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, checking the blame it looks like it was never used in the first place.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye, it's used in more places like bitcoingui.cpp though.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only see the .svg files in the bitcoingui.cpp , where /icons/lock_closed_"+sSheet imports the correctly styled .svg . Do you have a line number?

@skcin skcin merged commit c446adc into skcin:high-dpi-improvements Dec 10, 2017
@TheCharlatan TheCharlatan deleted the highdpi branch December 16, 2017 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants