Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/18381 get off alerts #230

Merged
merged 24 commits into from Jan 19, 2023
Merged

Feature/18381 get off alerts #230

merged 24 commits into from Jan 19, 2023

Conversation

nighthawk
Copy link
Member

@nighthawk nighthawk commented Jan 17, 2023 •
edited

Open action items:

  • Pass on UNNotificationRequest objects to host app
  • Opt-into this feature rather than always having it enabled (could be via the same mechanism as the point above)
  • Support the time-based "Your trip is starting soon" alerts (aka TRIP_START)
  • When stopping to monitoring, clear TKGeoMonitorManager.geofences
  • Stop monitoring when dismissing the TKUITripOverviewCard? Keep it and leave it to user to do that manually; so that they can get back to a trip

@nighthawk nighthawk marked this pull request as ready for review January 19, 2023 05:20
@julesian
Copy link
Contributor

lgtm

@nighthawk nighthawk merged commit 30da377 into pre-refactor/swiftify Jan 19, 2023
@nighthawk nighthawk deleted the feature/18381-get-off-alerts branch January 19, 2023 21:48
This was referenced Jan 19, 2023
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julesian julesian julesian approved these changes

Assignees

@julesian julesian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nighthawk @julesian