Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB 10.9.4 changes SHOW CREATE statement #193

Closed
Sparticuz opened this issue Nov 16, 2022 · 3 comments
Closed

MariaDB 10.9.4 changes SHOW CREATE statement #193

Sparticuz opened this issue Nov 16, 2022 · 3 comments
Labels

Comments

@Sparticuz
Copy link

Describe the bug
Updating to MariaDB 10.9.4 and I can no longer use skeema.
[WARN] Skipping table gen_territories: Skeema does not support generating a diff of this table. Use --debug to see which properties of this table are not supported.

--debug shows the following:

[DEBUG] The desired state ("to" side of diff) contains unexpected or unsupported clauses in SHOW CREATE TABLE.
                            --- desired state expected CREATE
                            +++ desired state actual SHOW CREATE
                            @@ -3,2 +3,2 @@
                            -  `TerritoryName` varchar(45) COLLATE utf8mb4_unicode_ci NOT NULL,
                            -  `sales_rep` varchar(45) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
                            +  `TerritoryName` varchar(45) NOT NULL,
                            +  `sales_rep` varchar(45) DEFAULT NULL,
                            @@ -6,3 +6,3 @@
                            -  `gdata_calendarid` varchar(191) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'This is the calendar ID for V1',
                            -  `gdata_sub` varchar(191) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'This is the subscriber for V2',
                            -  `gdata_access_token` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'This is the subscriber''s access toke for V2',
                            +  `gdata_calendarid` varchar(191) DEFAULT NULL COMMENT 'This is the calendar ID for V1',
                            +  `gdata_sub` varchar(191) DEFAULT NULL COMMENT 'This is the subscriber for V2',
                            +  `gdata_access_token` varchar(255) DEFAULT NULL COMMENT 'This is the subscriber''s access toke for V2',

Environment

  • Skeema version: skeema version 1.8.2-community, commit 1980132, released 2022-09-14T20:51:18Z
  • Database vendor, version, OS/platform: MariaDB 10.9.4 (docker tag mariadb:latest)

To Reproduce
Upgrade to MariaDB 10.9.4 and try to use skeema

Expected behavior
skeema works

Additional context
MariaDB/server@0703c9ec1e
MariaDB/server@0333ddd3ec
https://jira.mariadb.org/browse/MDEV-29446

@Sparticuz Sparticuz added the bug label Nov 16, 2022
@evanelias
Copy link
Contributor

Already fixed in main branch in f2dcaf8 last week (and quite annoyingly time-consuming to deal with I might add), there just hasn't been a new Skeema release yet.

@Sparticuz
Copy link
Author

Thank you

@evanelias
Copy link
Contributor

Skeema v1.9.0 has now been released, and contains this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants