Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skeema format: column collation statements removed when using mariadb:10.3.37 as flavor #195

Closed
markododa opened this issue Nov 25, 2022 · 3 comments
Labels

Comments

@markododa
Copy link

Not sure if this is a skeema bug or something with mariadb.

When using flavor=mariadb:10.3.37

[remote]
flavor=mariadb:10.3.37
host=localhost
port=3306
user=skeema-admin

skeema format

skeema format --workspace=docker remote

removes the COLLATE statement from the column definitions

for example

-  `cron` varchar(25) COLLATE utf8mb4_unicode_ci NOT NULL,
-  `status` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL,
+  `cron` varchar(25) NOT NULL,
+  `status` varchar(10) NOT NULL,

this does not happen when flavor is set to mariadb:10.3.36
The behavior persists between various skeema versions, i tested the following versions

skeema version 1.5.2-community,
skeema version 1.8.2-community
@evanelias
Copy link
Contributor

MariaDB changed the behavior of SHOW CREATE TABLE in their point releases this month (including 10.3.37), completely breaking compatibility with Skeema. Please see f2dcaf8 and #193. The next Skeema release (v1.9.0) should be out in 1-2 weeks.

@markododa
Copy link
Author

Thank you!

@evanelias
Copy link
Contributor

Skeema v1.9.0 has now been released, and contains this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants