-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for org links. #206
Conversation
171dce7
to
3c412ad
Compare
Hm, there seem to be a PR already opened for this (#128) but it seems there are conflicts and it's 2 years old, so probably abandoned? Also, doesn't work on org-mode 9 which is the "standard" these days. |
The difficulty with these Org pull requests is that I don't use Org and I'm unfamiliar with how it's used. I don't really have the context I need make a decision about merging, so they just languish. That's why elfeed-org is a separate package, maintained by @remyhonig who (I presume) knows this stuff. |
@skeeto The problem is that You can think of org files as glorified markdown. Instead of just normal links (to websites), it supports links to email (gnus), files, bibtex, irc, bookmarks, git commits, search strings, direds, grep result sets and many more things. Basically a link provites a syntax to store "something" which when run provides the desired outcome. So when I create such a link in my notes file which points to a mail or an elfeed entry, I can just click on it (or Elfeed already provides integration with bookmarks, which is in principle very similar, org links are just textual representation for the same concept. |
I vote for it. |
Alright, this seem simple enough, so I merged it. The header says to |
@skeeto Provided this is installed via something that loads the generated autoloads, yes it will work as you describe. If you |
I have elfeed 2.1.1 on Emacs 24.5 and org 9.0.7 and it works fine. Can you show the entire template? Sometimes you need to quote the arguments inside the templates (when org isn't smart enough). |
I'm not sure what is going on to be honest. If you know how the elisp debugger works maybe you can step through The properties are only stored when you capture from the "show" mode (viewing an entry) not from the search. Are you doing that? |
This is based on #34 but also stores all the related entry metadata, so they can be used in capture templates.
Also adds support for org mode 9+ which uses different link syntax/functions.
For use in templates, you can use all the metadata under
:elfeed-entry-
namespace, for example