Rewrite as a recursive descent parser #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeggse
force-pushed
the
recursive-descent
branch
2 times, most recently
from
20d2aff
to
dcb1137
Compare
skeggse
force-pushed
the
recursive-descent
branch
4 times, most recently
from
ecc5cbd
to
dbe98a6
Compare
This simplifies some of our validation, and opens the door to let users of the module run their own DNS check through a general-purpose API.
skeggse
force-pushed
the
recursive-descent
branch
2 times, most recently
from
4116c9b
to
711c161
Compare
Per RFC 6531, the addition of unicode doesn't extend to domain literals.
skeggse
force-pushed
the
recursive-descent
branch
from
711c161
to
a622c30
Compare
|
I think this is now feature-complete with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies some of our validation, and opens the door to let users of the module run their own DNS check through a general-purpose API. As such, we're working towards #4.
Will need to be updated to reflect the latest PRs.