Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a11y Warnings #2643

Merged
merged 8 commits into from
May 6, 2024
Merged

Resolve a11y Warnings #2643

merged 8 commits into from
May 6, 2024

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Apr 30, 2024

Linked Issue

Closes #2632

Description

Resolve a11y warnings in in the Skeleton doc site and multiple components

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@endigo9740 endigo9740 linked an issue Apr 30, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: 7d697e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-next ❌ Failed (Inspect) May 1, 2024 7:32pm
skeleton-themes ❌ Failed (Inspect) May 1, 2024 7:32pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
skeleton-docs ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 7:32pm

@endigo9740 endigo9740 deleted the bugfix/resolve-a11y-warnings branch May 6, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve a11y warnings in multiple components
2 participants