-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/range slider new props #1069
Feat/range slider new props #1069
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@SebasF1349 I love the concept of this feature, but I think the way it's being implemented could use it a bit of adjustment. I won't have time to write a proper set of instructions here today, but just wanted to let you know where we are on this. I definitely think this will be a valuable feature though. We're juggling a few things right now, so expect this sometime early next week. Thanks! |
@SebasF1349 just wanted to let you know I haven't forgot about this. We may actually opt to hold off for this post v1.0 just so we can take the proper amount of time to implement and test this. If you're ok with that I'll circle back with you next week. But general idea is I like your idea of being able to feed in the data points, but I'd like to also include a means to automate this. I haven't quite formalized the specifics for how to do this, but general idea is if I have 100 ticks, I'm not going to want to have to manually label each of those. Perhaps this is a second or addition feature that's enabled that basically tells the component "do this for me". I'll need to prototype a bit, but I will follow up. Thanks again for your patience in the meantime. |
No problem! Glad you liked the idea. My pr was definitely not production ready so I knew it will need some work. Also, too much work this last weeks, so completely understandable it gets pushed to after v1. Let me know if I can help in anything regarding this. |
@SebasF1349 as discussed yesterday I'm closing this, but will refer to this in the ticket when I generate my iteration of this. |
Before submitting the PR:
npm run test
?branch -m new-branch-name
What does your PR address?
Fixes #1066
Important notes: