Skip to content

Commit

Permalink
Skip invalid end2end test for ES2
Browse files Browse the repository at this point in the history
Previously, the incomplete framebuffer depth stencil attachment
test would run on ES2 if GL_OES_packed_depth_stencil were present.
This is insufficient since it uses the GL_DEPTH_STENCIL_ATTACHMENT
enum, which is not introduced in any extension prior to ES3. The
test has been disabled on ES2, regardless of extensions.

Bug: angleproject:4454
Test: angle_end2end_tests --gtest_filter=StateChangeTest.FramebufferIncompleteDepthStencilAttachment/*
Change-Id: Ic5a6a521e35b49c5d723b33f588fa608264d6390
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090783
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
  • Loading branch information
Brandon Schade authored and Commit Bot committed Mar 7, 2020
1 parent 03ed5f6 commit 0c9b6ab
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/tests/gl_tests/StateChangeTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,8 @@ TEST_P(StateChangeTest, FramebufferIncompleteStencilAttachment)
}

// Test that Framebuffer completeness caching works when depth-stencil attachments change.
TEST_P(StateChangeTest, FramebufferIncompleteDepthStencilAttachment)
TEST_P(StateChangeTestES3, FramebufferIncompleteDepthStencilAttachment)
{
ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 &&
!IsGLExtensionEnabled("GL_OES_packed_depth_stencil"));

glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
glBindTexture(GL_TEXTURE_2D, mTextures[0]);
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 16, 16, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
Expand Down

0 comments on commit 0c9b6ab

Please sign in to comment.