Skip to content

Commit

Permalink
tests/regres/export_to_sheets: Fix off-by-one in loop
Browse files Browse the repository at this point in the history
We weren't looking at the most recent change.
Kinda important when that's typically the new test list you're trying to export.

Change-Id: I0e312dbde0ae54feb0641a658eebc73bbdb47eaa
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26928
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
  • Loading branch information
ben-clayton committed Mar 12, 2019
1 parent abb5785 commit 6193cb1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/regres/export_to_sheets.go
Expand Up @@ -124,7 +124,7 @@ func run() error {

rowInsertionPoint := 1 + len(hashValues)

for i := len(changes) - 1; i > 0; i-- {
for i := len(changes) - 1; i >= 0; i-- {
change := changes[i]
if !strings.HasPrefix(change.Subject, consts.TestListUpdateCommitSubjectPrefix) {
continue
Expand Down

0 comments on commit 6193cb1

Please sign in to comment.