Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to bower #27

Closed
callumacrae opened this issue Feb 28, 2014 · 14 comments · Fixed by #30
Closed

Add to bower #27

callumacrae opened this issue Feb 28, 2014 · 14 comments · Fixed by #30

Comments

@callumacrae
Copy link
Contributor

bower install dragdealer currently links to this: https://github.com/yahyaKacem/dragdealer, which is out of date.

@ovidiuch
Copy link
Owner

Well we could create the bower config in this repo but I think @yahyaKacem would have to unregister their repo to publish it again with the official repo. I'm not very familiar with Bower but I found this bower/bower#120

@callumacrae
Copy link
Contributor Author

If @yahyaKacem doesn't unregister their repo, you could always publish it as something like "dragdealer.js". Hopefully they will, though.

@yahyaKacem
Copy link

sorry I don't know how to unregister it, if you can point me to a link describing how, i'll do it.

@callumacrae
Copy link
Contributor Author

Post on bower/bower#120 asking for your dragdealer package to be removed. Thanks!

@ooxi
Copy link
Contributor

ooxi commented Mar 3, 2014

How cool is that, I just wanted to ask you to get in contact with @yahyaKacem but he already responeded!

@ovidiuch
Copy link
Owner

ovidiuch commented Mar 3, 2014

@ooxi yup, you can tell the real value of GitHub in moments like this. Now it's just a matter of time until the guys at @bower do their manual labor :)

@ovidiuch
Copy link
Owner

ovidiuch commented Mar 5, 2014

I can see it takes a while for the bower people to unregister a repo. In the meantime, @callumacrae or anyone else, feel free to create a small pull request with a minimal bower.json config in place (should be very similar with the npm one)

@ooxi
Copy link
Contributor

ooxi commented Mar 16, 2014

@yahyaKacem since bower seems to take ages to update their repository, could you clone skidding's?

@ovidiuch
Copy link
Owner

Not a bad idea, do you think it would work if @yahyaKacem removes their
repo and forks dragdealer instead?

On Sunday, March 16, 2014, ooxi notifications@github.com wrote:

@yahyaKacem https://github.com/yahyaKacem since bower seems to take
ages to update their repository, could you clone skidding's?


Reply to this email directly or view it on GitHubhttps://github.com//issues/27#issuecomment-37751049
.

Best regards,
Ovidiu Cherecheş

@yahyaKacem
Copy link

Check it now.

@simshanith
Copy link

So, first off, thanks for publishing such an awesome update, and making it available here. I just pulled in the latest with Bower, and now it doesn't include the minified lib/dragdealer.min.js thanks to the lib/ ignore rule. Not sure how you want to handle this; but I think it's nice to have available to bower users.

@ovidiuch
Copy link
Owner

The main path points to src/dragdealer.js, why is that no good? I'm not sure what the best Bower flow is but I would expect to minify all files inside a project myself using grunt/gulp/etc. - I looked at other libraries and saw that they point to the unminified source as well in their bower config. Let me know what you think

@yahyaKacem
Copy link

Here I added the minified file.

@simshanith
Copy link

Thanks @yahyaKacem !

@skidding , main as src/dragdealer.js is good. I'm not quite sure what the best Bower flow is either, so erring on the side of flexibility makes sense to me. On some projects, simply concatenating vendor-provided minified scripts is all you need. Some vendor projects may minify with Google Closure Compiler or have special Uglify flags (etc.) that I, as a vendor library consumer, don't want to worry about. By including a minified file that passes unit tests the library consumer doesn't need to worry about the minification implementation, which I think is a good thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants