Skip to content

Commit

Permalink
odroid/common: disable buggy emmc hotplug (set non-removable)
Browse files Browse the repository at this point in the history
Fixes log spam about clock speed changing when attempting to detect hot plugged
emmc card.

Drop previous patch which removed the log line to fix this.

https://forum.odroid.com/viewtopic.php?f=146&t=40154&p=304817#p304817

Signed-off-by: Christian Stewart <christian@paral.in>
  • Loading branch information
paralin committed Sep 1, 2020
1 parent 10c739e commit fd3fefc
Show file tree
Hide file tree
Showing 5 changed files with 38 additions and 43 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
From d7d4e092dc03982645dfce46cdf64f09bec1d88f Mon Sep 17 00:00:00 2001
From 685e96d29093d426e3e926837a6848b2d6657029 Mon Sep 17 00:00:00 2001
From: Christian Stewart <christian@paral.in>
Date: Sun, 9 Dec 2018 00:27:49 -0800
Subject: [PATCH 1/2] Fix boot failure
Subject: [PATCH] Fix boot failure

Sourced fix from:

Expand All @@ -14,7 +14,7 @@ Signed-off-by: Christian Stewart <christian@paral.in>
1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
index 4849b44c3549..f0ccd333f8dd 100755
index 9e3f078c19b0..f1d07b90cfcd 100755
--- a/drivers/regulator/s2mps11.c
+++ b/drivers/regulator/s2mps11.c
@@ -1094,8 +1094,21 @@ static const struct regulator_desc s2mpu02_regulators[] = {
Expand Down Expand Up @@ -69,5 +69,5 @@ index 4849b44c3549..f0ccd333f8dd 100755
}

--
2.18.1
2.28.0

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
From ecebe320314300e71282bdf382e138c2691cd3bf Mon Sep 17 00:00:00 2001
From 33595f2b5a5c3a066becf5bec2b582cab5d9418d Mon Sep 17 00:00:00 2001
From: Christian Stewart <christian@paral.in>
Date: Sun, 9 Dec 2018 00:29:04 -0800
Subject: [PATCH 2/2] Increase DMA coherent pool to 2M
Subject: [PATCH] Increase DMA coherent pool to 2M

---
arch/arm/mm/dma-mapping.c | 2 +-
Expand All @@ -21,5 +21,5 @@ index 0e1e56a50d75..33aa3016e63b 100644

static size_t atomic_pool_size = DEFAULT_DMA_COHERENT_POOL_SIZE;
--
2.18.1
2.28.0

Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
From 4c98804462c3c042a32f8002a55c7e3539b59a1c Mon Sep 17 00:00:00 2001
From: Christian Stewart <christian@paral.in>
Date: Mon, 31 Aug 2020 19:13:42 -0700
Subject: [PATCH] exynos5422: odroidxu3: mark mmc0 as non-removable to disable
hotplug

Prevents spamming of frequency-change log messages when attempting to detect
hot-plug of eMMC.

Signed-off-by: Christian Stewart <christian@paral.in>
---
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index eb82d34ceec8..05e5a20e5179 100755
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -147,6 +147,7 @@
status = "okay";
mmc-pwrseq = <&emmc_pwrseq>;
card-detect-delay = <200>;
+ non-removable;
samsung,dw-mshc-ciu-div = <3>;
samsung,dw-mshc-sdr-timing = <0 4>;
samsung,dw-mshc-ddr-timing = <0 2>;
--
2.28.0

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 491367493f2a6d9f9f4f9222b4e7eb480d76fe5f Mon Sep 17 00:00:00 2001
From 1175a8d827e854ca884eb5aede139c975d96278b Mon Sep 17 00:00:00 2001
From: Christian Stewart <christian@paral.in>
Date: Wed, 24 Apr 2019 12:17:42 -0700
Subject: [PATCH] Disable PIDs cgroup to fix boot
Expand Down Expand Up @@ -67,5 +67,5 @@ index ae448f7632cc..bc3918171166 100644
obj-$(CONFIG_CPUSETS) += cpuset.o
obj-$(CONFIG_CGROUP_DEBUG) += debug.o
--
2.21.0
2.28.0

0 comments on commit fd3fefc

Please sign in to comment.