replace franchisee.transfer with send to avoid malicious franchisee f…

…reezing trust. Closes #1 thanks https://github.com/NickErrant
skilesare · Nov 9, 2017 · a2db361 · a2db361
1 parent 9577c32
commit a2db361
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/contracts/FiatTrust.sol b/contracts/FiatTrust.sol
@@ -433,7 +433,10 @@ contract FiatTrust {
     else{
       custodian.transfer( (_feeAmount / franchiseeFactor).mul(franchiseeFactor - 1 ) );
       FeePaid(custodian, (_feeAmount / franchiseeFactor).mul(franchiseeFactor - 1) );
-      franchisee.transfer(_feeAmount / franchiseeFactor);
+      //use send instead of tranfer to make franchisee responsible for accepting payment
+      //https://github.com/skilesare/catallaxtrust/issues/1
+      // h/t to https://github.com/NickErrant
+      franchisee.send(_feeAmount / franchiseeFactor);
       FeePaid( custodian, _feeAmount / franchiseeFactor);
     }
   }